Update key explorer to use dialog element for help dialog. (mathjax/MathJax#3405) #1334
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #1334 +/- ##
========================================
Coverage 86.72% 86.72%
========================================
Files 337 337
Lines 84145 84145
Branches 4769 4769
========================================
Hits 72971 72971
- Misses 11151 11174 +23
+ Partials 23 0 -23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Just for the record, the reason for the fallback is that |
| (help.childNodes[1] as HTMLElement).innerHTML = helpMessage(title, select); | ||
| document.body.append(helpBackground); | ||
| help.focus(); | ||
| if (isDialog) { |
There was a problem hiding this comment.
Can we add a comment, that we can simplify this in two years.
There was a problem hiding this comment.
actually, #1357 supercedes this PR, so I will add the comment there. Most of the changes here are moved to the new dialog class in that PR, and merging this PR will cause a merge conflict later, so I'm going to close this one in favor of that one rather than merge it.
The work you have done in reviewing this, however, is not wasted, as this code is used in that PR.
|
Closing in favor of #1357. |
This PR allows the KeyExplorer to use a
<dialog>element when the browser supports that, and uses the current method when that isn't available. In the latter case, we still create adialogelement, but it acts like a custom element in that case, since it isn't implemented directly.This resolve the
z-indexissue reported in mathjax/MathJax#3405.